tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py - Issue 273103003: Add responsiveness_metric for timeline_based_measurement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py

Issue 273103003: Add responsiveness_metric for timeline_based_measurement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Chris' comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/timeline/trace_event_importer.py ('k') | tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py » ('j') | tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py

diff --git a/tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py b/tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py

index 3b9b33a444ff2fc245b215b3a15066d6437ab9e2..c4b8c12d0116ba5032fe945b19a0857802c1c4dd 100644

--- a/tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py

+++ b/tools/telemetry/telemetry/core/timeline/trace_event_importer_unittest.py

@@ -945,6 +945,8 @@ class TraceEventTimelineImporterTest(unittest.TestCase):

self.assertEqual('a', parent_slice.name)

self.assertEqual('foo', parent_slice.category)

self.assertEqual(0, parent_slice.start)

+ self.assertAlmostEqual(17/1000.0, parent_slice.thread_start)

+ self.assertAlmostEqual(25/1000.0, parent_slice.thread_end)

self.assertEqual(2, len(parent_slice.sub_slices))

sub_slice = parent_slice.sub_slices[0]