tools/telemetry/telemetry/web_perf/metrics/smoothness.py - Issue 273103003: Add responsiveness_metric for timeline_based_measurement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/smoothness.py

Issue 273103003: Add responsiveness_metric for timeline_based_measurement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« tools/telemetry/telemetry/web_perf/metrics/mainthread_jank.py ('K') | « tools/telemetry/telemetry/web_perf/metrics/mainthread_jank_unittest.py ('k') | tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py » ('j') | tools/telemetry/telemetry/web_perf/metrics/unittest_util.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/web_perf/metrics/smoothness.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/smoothness.py b/tools/telemetry/telemetry/web_perf/metrics/smoothness.py

index c2a8b54d2bfd458e4df1b5f7bf81262a2406a652..fff1f1ec7a2012894c2e466537e6f157c77e53d2 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/smoothness.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/smoothness.py

@@ -13,6 +13,7 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):

super(SmoothnessMetric, self).__init__()

def AddResults(self, model, renderer_thread, interaction_records, results):

+ self.VerifyNonOverlappedRecords(interaction_records)

renderer_process = renderer_thread.parent

stats = rendering_stats.RenderingStats(

renderer_process, model.browser_process,