Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 273103002: MIPS: Reland r20974: Unify and simplify the FastCloneShallowArrayStub. (Closed)

Created:
6 years, 7 months ago by kilvadyb
Modified:
6 years, 7 months ago
Reviewers:
kisg, Paul Lind, palfia, danno, dusmil
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@gbl
Visibility:
Public.

Description

MIPS: Reland r20974: Unify and simplify the FastCloneShallowArrayStub. Port r21230 (56ef3ac) Original commit message: - Don't bake in length/capacity into full codegen calls of stubs, allowing boilerplates to increase their capacity without regenerating code. - Unify all variants of the clone stub into a single, length-independent version. - Various tweaks to make sure that the clone stub doesn't spill and therefore need an eager stack frame. - Handle all lengths of array literals in the fast case. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M src/mips/code-stubs-mips.cc View 3 chunks +14 lines, -0 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
6 years, 7 months ago (2014-05-09 17:08:06 UTC) #1
Paul Lind
lgtm
6 years, 7 months ago (2014-05-09 17:27:57 UTC) #2
Paul Lind
6 years, 7 months ago (2014-05-09 17:30:34 UTC) #3
Committed as r21239.

Powered by Google App Engine
This is Rietveld 408576698