Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Unified Diff: components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc

Issue 2731013002: ActivationStateComputingThrottle unit tests (Closed)
Patch Set: engedy review2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc
diff --git a/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc b/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc
index 84b1aa55778efc81d734dfb1e5b81666c0e8ca3a..198cd1f1e1934c17079f8c9a9c77682f67310e7e 100644
--- a/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc
+++ b/components/subresource_filter/content/browser/subframe_navigation_filtering_throttle_unittest.cc
@@ -12,6 +12,7 @@
#include "base/run_loop.h"
#include "base/strings/stringprintf.h"
#include "components/subresource_filter/content/browser/async_document_subresource_filter.h"
+#include "components/subresource_filter/content/browser/async_document_subresource_filter_test_utils.h"
#include "components/subresource_filter/core/common/activation_level.h"
#include "components/subresource_filter/core/common/activation_state.h"
#include "components/subresource_filter/core/common/test_ruleset_creator.h"
@@ -72,16 +73,16 @@ class SubframeNavigationFilteringThrottleTest
ruleset_handle_ =
base::MakeUnique<VerifiedRuleset::Handle>(dealer_handle_.get());
+ testing::TestActivationStateCallbackReceiver activation_state;
parent_filter_ = base::MakeUnique<AsyncDocumentSubresourceFilter>(
ruleset_handle_.get(),
AsyncDocumentSubresourceFilter::InitializationParams(
document_url, ActivationLevel::ENABLED,
false /* measure_performance */),
- base::Bind([](ActivationState state) {
- EXPECT_EQ(ActivationLevel::ENABLED, state.activation_level);
- }),
- base::OnceClosure());
+ activation_state.GetCallback(), base::OnceClosure());
RunUntilIdle();
+ activation_state.ExpectReceivedOnce(
+ ActivationState(ActivationLevel::ENABLED));
}
void RunUntilIdle() { base::RunLoop().RunUntilIdle(); }
« no previous file with comments | « components/subresource_filter/content/browser/async_document_subresource_filter_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698