Add --print-dependencies to gen_snapshot

Add --print-dependencies to gen_snapshot

Needed to fix https://github.com/flutter/flutter/issues/8514.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/f10d354e985724efa722fee2ac2a6216e73f8543

[goderbauer, 2017-03-03 20:16:22]

Description was changed from

==========
Add --print-dependencies to gen_snapshot

Needed to fix https://github.com/flutter/flutter/issues/8514.

BUG=
==========

to

==========
Add --print-dependencies to gen_snapshot

Needed to fix https://github.com/flutter/flutter/issues/8514.

BUG=
==========

[goderbauer, 2017-03-03 20:16:22]

goderbauer@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2017-03-03 20:40:25]

Paths with spaces would be an issue on all platforms, no? Do we need to escape
paths in the Makefile instead/also?

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:689: ASSERT(dependencies_filename != NULL ||
print_dependencies);
ASSERT((dependencies_filename != NULL) || print_dependencies);

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:691: File* file;
file = NULL;
(-Werror=maybe-uninitialized)

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:1599: if (dependencies_filename != NULL ||
print_dependencies) {
if ((dependencies_filename != NULL) || print_dependencies) {

[goderbauer, 2017-03-03 21:01:41]

It is my understanding that Makefiles don't have good support for spaces in
paths. See
https://www.cmcrossroads.com/article/gnu-make-meets-file-names-spaces-them or
http://savannah.gnu.org/bugs/?712.

On 2017/03/03 20:40:25, rmacnak wrote:
> Paths with spaces would be an issue on all platforms, no? Do we need to escape
> paths in the Makefile instead/also?
> 
> https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc
> File runtime/bin/gen_snapshot.cc (right):
> 
>
https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:689: ASSERT(dependencies_filename != NULL ||
> print_dependencies);
> ASSERT((dependencies_filename != NULL) || print_dependencies);
> 
>
https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:691: File* file;
> file = NULL;
> (-Werror=maybe-uninitialized)
> 
>
https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
> runtime/bin/gen_snapshot.cc:1599: if (dependencies_filename != NULL ||
> print_dependencies) {
> if ((dependencies_filename != NULL) || print_dependencies) {

[goderbauer, 2017-03-03 21:04:22]

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc
File runtime/bin/gen_snapshot.cc (right):

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:689: ASSERT(dependencies_filename != NULL ||
print_dependencies);
On 2017/03/03 20:40:25, rmacnak wrote:
> ASSERT((dependencies_filename != NULL) || print_dependencies);

Done.

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:691: File* file;
On 2017/03/03 20:40:25, rmacnak wrote:
> file = NULL;
> (-Werror=maybe-uninitialized)

Done.

https://codereview.chromium.org/2730943003/diff/1/runtime/bin/gen_snapshot.cc...
runtime/bin/gen_snapshot.cc:1599: if (dependencies_filename != NULL ||
print_dependencies) {
On 2017/03/03 20:40:25, rmacnak wrote:
> if ((dependencies_filename != NULL) || print_dependencies) {

Done.

[rmacnak, 2017-03-03 21:26:05]

lgtm

[rmacnak, 2017-03-03 21:28:29]

Description was changed from

==========
Add --print-dependencies to gen_snapshot

Needed to fix https://github.com/flutter/flutter/issues/8514.

BUG=
==========

to

==========
Add --print-dependencies to gen_snapshot

Needed to fix https://github.com/flutter/flutter/issues/8514.

BUG=
R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f10d354e985724efa722fee2ac2a6216e73f8543
==========

[rmacnak, 2017-03-03 21:28:30]

Committed patchset #2 (id:20001) manually as
f10d354e985724efa722fee2ac2a6216e73f8543 (presubmit successful).