third_party/WebKit/Source/core/mojo/MojoHandle.cpp - Issue 2730943002: XMLHttpRequest: return null upon failing responseArrayBuffer allocation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/mojo/MojoHandle.cpp

Issue 2730943002: XMLHttpRequest: return null upon failing responseArrayBuffer allocation. (Closed)

Patch Set: mirror updated spec, and return |null| for failed allocs Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/mojo/MojoHandle.cpp

diff --git a/third_party/WebKit/Source/core/mojo/MojoHandle.cpp b/third_party/WebKit/Source/core/mojo/MojoHandle.cpp

index d2441055265f982ca4f212811d946c9ef5815aff..b48b61fe850d08039d9324fd29dbecb7cacdcead 100644

--- a/third_party/WebKit/Source/core/mojo/MojoHandle.cpp

+++ b/third_party/WebKit/Source/core/mojo/MojoHandle.cpp

@@ -79,7 +79,9 @@ void MojoHandle::readMessage(const MojoReadMessageFlags& flagsDict,

return;

}

- DOMArrayBuffer* buffer = DOMArrayBuffer::createUninitialized(numBytes, 1);

+ DOMArrayBuffer* buffer =

+ DOMArrayBuffer::createUninitializedOrNull(numBytes, 1);

+ CHECK(buffer);

Vector<::MojoHandle, kHandleVectorInlineCapacity> rawHandles(numHandles);

result = MojoReadMessage(m_handle->value(), buffer->data(), &numBytes,

rawHandles.data(), &numHandles, flags);