Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 2730873002: Avoid fetching RFH from navigation handle for not committed navigations. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/devtools/render_frame_devtools_agent_host.cc
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc
index e5d64bff2495b7f09f841a5510aeccd5034d340d..478d1f0fb6b08056be7f2beb6cc04e58c718fef4 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.cc
+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc
@@ -657,8 +657,8 @@ void RenderFrameDevToolsAgentHost::DidFinishNavigation(
}
if (session())
protocol::TargetHandler::FromSession(session())->UpdateServiceWorkers();
- } else if (pending_ &&
- pending_->host() == navigation_handle->GetRenderFrameHost()) {
+ } else if (pending_ && pending_->host()->GetFrameTreeNodeId() ==
+ navigation_handle->GetFrameTreeNodeId()) {
DiscardPending();
}
DCHECK(CheckConsistency());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698