Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 273073002: Changes code using Compositor to pass in ContextFactory (Closed)

Created:
6 years, 7 months ago by sky
Modified:
6 years, 6 months ago
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, Ian Vollick, tfarina, ben+aura_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, ben+corewm_chromium.org, piman+watch_chromium.org, ben+views_chromium.org, kalyank, danakj+watch_chromium.org, cc-bugs_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

This enables us to get rid of ContextFactory::GetInstance() so that the Compositor (and soon aura) can be used from multiple threads. BUG=none TEST=none R=ben@chromium.org

Patch Set 1 #

Patch Set 2 : dont show inflight patch #

Patch Set 3 : merge to trunk #

Patch Set 4 : merge to trunk #

Patch Set 5 : merge to trunk #

Patch Set 6 : cleanup #

Patch Set 7 : fix mojo #

Patch Set 8 : fix keyboardcontrollertest #

Patch Set 9 : fix aura:bench, aura:main and snapshot_aura_unittest #

Patch Set 10 : fix browserwithtestwindowtest #

Patch Set 11 : fix more tests #

Patch Set 12 : Fix tooltip on chromeos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -173 lines) Patch
M apps/shell/browser/shell_desktop_controller.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ash/display/display_controller.h View 1 2 3 chunks +7 lines, -1 line 0 comments Download
M ash/display/display_controller.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M ash/display/mirror_window_controller.h View 3 chunks +4 lines, -1 line 0 comments Download
M ash/display/mirror_window_controller.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ash/display/virtual_keyboard_window_controller.h View 3 chunks +7 lines, -1 line 0 comments Download
M ash/display/virtual_keyboard_window_controller.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M ash/host/ash_remote_window_tree_host_win.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/host/ash_remote_window_tree_host_win.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M ash/host/ash_window_tree_host_init_params.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M ash/host/ash_window_tree_host_init_params.cc View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M ash/host/ash_window_tree_host_ozone.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M ash/host/ash_window_tree_host_win.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M ash/host/ash_window_tree_host_x11.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/host/ash_window_tree_host_x11.cc View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M ash/host/ash_window_tree_host_x11_unittest.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M ash/shell.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ash/shell.cc View 1 2 3 4 chunks +4 lines, -3 lines 0 comments Download
M ash/shell/content_client/shell_browser_main_parts.cc View 1 2 3 2 chunks +5 lines, -2 lines 0 comments Download
M ash/shell/window_watcher_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ash/shell_init_params.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M ash/shell_init_params.cc View 1 2 3 4 5 1 chunk +5 lines, -3 lines 0 comments Download
M ash/test/ash_test_base.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ash/test/ash_test_helper.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/ash_init.cc View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 1 2 4 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_desktop_window_tree_host_x11.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.h View 1 2 3 3 chunks +7 lines, -4 lines 0 comments Download
M chrome/test/base/browser_with_test_window_test.cc View 1 2 3 4 5 6 7 8 9 3 chunks +11 lines, -6 lines 0 comments Download
M chrome/test/base/view_event_test_base.h View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M chrome/test/base/view_event_test_base.cc View 1 2 3 4 5 6 7 8 9 5 chunks +35 lines, -4 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/media/capture/desktop_capture_device_aura_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M content/shell/browser/shell_platform_data_aura.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/shell/browser/shell_views.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +6 lines, -2 lines 0 comments Download
M mojo/aura/window_tree_host_mojo.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/bench/bench_main.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/demo/demo_main.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/remote_window_tree_host_win.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M ui/aura/test/aura_test_base.h View 3 chunks +7 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_base.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ui/aura/test/test_screen.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/aura/test/test_screen.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/aura/window_event_dispatcher_unittest.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M ui/aura/window_tree_host.h View 3 chunks +5 lines, -2 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M ui/aura/window_tree_host_mac.h View 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_mac.mm View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/aura/window_tree_host_ozone.h View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_ozone.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M ui/aura/window_tree_host_win.h View 1 chunk +6 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_win.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/aura/window_tree_host_x11.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/aura/window_tree_host_x11.cc View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -2 lines 0 comments Download
M ui/snapshot/snapshot_aura_unittest.cc View 1 2 3 4 5 6 7 8 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/corewm/DEPS View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/corewm/capture_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 10 chunks +19 lines, -10 lines 0 comments Download
M ui/views/examples/content_client/examples_browser_main_parts.cc View 1 2 3 4 5 6 7 8 9 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/views_test_base.h View 1 2 3 chunks +7 lines, -0 lines 0 comments Download
M ui/views/test/views_test_base.cc View 1 2 3 4 5 6 7 8 9 10 2 chunks +10 lines, -5 lines 0 comments Download
M ui/views/test/views_test_helper.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/test/views_test_helper.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/test/views_test_helper_aura.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/test/views_test_helper_aura.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 2 3 4 chunks +6 lines, -4 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 2 7 chunks +12 lines, -8 lines 0 comments Download
M ui/wm/test/wm_test_helper.h View 1 2 2 chunks +6 lines, -1 line 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sky
6 years, 7 months ago (2014-05-20 18:17:03 UTC) #1 
Sorry for the large review. It's mostly trivial changes to pass through the
ContextFactory.

Powered by Google App Engine
This is Rietveld 408576698