Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: components/browsing_data/core/browsing_data_utils.cc

Issue 2730703003: Change CBD layout and texts (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_counter_utils.cc ('k') | components/browsing_data_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/browsing_data/core/browsing_data_utils.cc
diff --git a/components/browsing_data/core/browsing_data_utils.cc b/components/browsing_data/core/browsing_data_utils.cc
index d353f009cfed075ca9361a78be9c48d8c6d8f43d..9f1f34fb46861c64f83d21c7110d7d2d5b603b1e 100644
--- a/components/browsing_data/core/browsing_data_utils.cc
+++ b/components/browsing_data/core/browsing_data_utils.cc
@@ -86,8 +86,10 @@ base::string16 GetCounterTextFromResult(
? IDS_DEL_PASSWORDS_COUNTER
: IDS_DEL_DOWNLOADS_COUNTER,
count);
- } else if (pref_name == browsing_data::prefs::kDeleteBrowsingHistory ||
- pref_name == browsing_data::prefs::kDeleteBrowsingHistoryBasic) {
+ } else if (pref_name == browsing_data::prefs::kDeleteBrowsingHistoryBasic) {
+ // The basic tab doesn't show history counter results.
+ NOTREACHED();
+ } else if (pref_name == browsing_data::prefs::kDeleteBrowsingHistory) {
// History counter.
const browsing_data::HistoryCounter::HistoryResult* history_result =
static_cast<const browsing_data::HistoryCounter::HistoryResult*>(
@@ -95,7 +97,6 @@ base::string16 GetCounterTextFromResult(
browsing_data::BrowsingDataCounter::ResultInt local_item_count =
history_result->Value();
bool has_synced_visits = history_result->has_synced_visits();
-
text = has_synced_visits
? l10n_util::GetPluralStringFUTF16(
IDS_DEL_BROWSING_HISTORY_COUNTER_SYNCED, local_item_count)
« no previous file with comments | « chrome/browser/browsing_data/browsing_data_counter_utils.cc ('k') | components/browsing_data_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698