chrome/android/java/res/layout/preference_spinner_single_line.xml - Issue 2730703003: Change CBD layout and texts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/layout/preference_spinner_single_line.xml

Issue 2730703003: Change CBD layout and texts (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/divider_preference_with_bottom_padding.xml ('k') | chrome/android/java/res/layout/preference_spinner_single_line_item.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/preference_spinner_single_line.xml

diff --git a/chrome/android/java/res/layout/preference_spinner_single_line.xml b/chrome/android/java/res/layout/preference_spinner_single_line.xml

index d5f0efae042320176aa6b18dfbdada272de5cc84..a51c96fb944f31e762a03d87a14d0c3a25d7dd85 100644

--- a/chrome/android/java/res/layout/preference_spinner_single_line.xml

+++ b/chrome/android/java/res/layout/preference_spinner_single_line.xml

@@ -3,28 +3,28 @@

Use of this source code is governed by a BSD-style license that can be

found in the LICENSE file. -->

-

+<!-- Layout used by SpinnerPreference if singleLine is set to true and the device's smallest width

+ is less than 360dp. This layout doesn't actually use a single line for text and spinner but is

+ used as a fallback for small devices. -->

-<RelativeLayout

+<LinearLayout

xmlns:android="http://schemas.android.com/apk/res/android"

style="@style/PreferenceLayout"

android:layout_width="match_parent"

- android:layout_height="wrap_content">

+ android:layout_height="wrap_content"

+ android:orientation="vertical">

<TextView

android:id="@+id/title"

- style="@style/PreferenceTitle"

- android:textAlignment="viewStart"

android:layout_height="wrap_content"

- android:layout_width="wrap_content"

- android:layout_centerVertical="true"

- android:layout_alignParentStart="true"

- android:layout_toStartOf="@id/spinner" />

+ android:layout_width="match_parent" />

<Spinner

android:id="@+id/spinner"

android:layout_height="wrap_content"

- android:layout_width="wrap_content"

- android:layout_centerVertical="true"

- android:layout_alignParentEnd="true" />

-</RelativeLayout>

+ android:layout_width="match_parent"

+ android:textSize="16sp"

+ android:paddingStart="0dp"

+ android:paddingTop="6dp" />

+</LinearLayout>