Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3943)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

Issue 2730703003: Change CBD layout and texts (Closed)
Patch Set: readd hamcrest conditions Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
index 58eeac8e73fc8d5704e3f333d7251533a7534b7d..f8a7677e3e1e856736f4aea640ec744684a756b3 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java
@@ -121,9 +121,10 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment
@Override
public void onCounterFinished(String result) {
- mCheckbox.setSummaryOn(result);
if (ClearBrowsingDataTabsFragment.isFeatureEnabled()) {
msramek 2017/03/22 14:40:21 Please add a comment explaining why we branch here
dullweber 2017/03/23 10:22:34 Done.
- mCheckbox.setSummaryOff(result);
+ mCheckbox.setSummary(result);
+ } else {
+ mCheckbox.setSummaryOn(result);
}
if (mShouldAnnounceCounterResult) {
mCheckbox.announceForAccessibility(result);
@@ -234,7 +235,7 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment
/**
* An option to be shown in the time period spiner.
*/
- private static class TimePeriodSpinnerOption {
+ protected static class TimePeriodSpinnerOption {
private int mTimePeriod;
private String mTitle;
@@ -356,7 +357,7 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment
* Returns the Array of time periods. Options are displayed in the same order as they appear
* in the array.
*/
- private TimePeriodSpinnerOption[] getTimePeriodSpinnerOptions() {
+ protected TimePeriodSpinnerOption[] getTimePeriodSpinnerOptions() {
Activity activity = getActivity();
TimePeriodSpinnerOption[] options = new TimePeriodSpinnerOption[] {

Powered by Google App Engine
This is Rietveld 408576698