chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc - Issue 2730703003: Change CBD layout and texts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 2730703003: Change CBD layout and texts (Closed)

Patch Set: try fix tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/browsing_data/browsing_data_counter_utils.h ('K') | « chrome/browser/ui/webui/options/clear_browser_data_handler.cc ('k') | components/browsing_data/core/browsing_data_utils.h » ('j') | components/browsing_data/core/browsing_data_utils.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h"	5 #include "chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler. h"

6	6

7 #include <stddef.h>	7 #include <stddef.h>

8	8

9 #include "base/macros.h"	9 #include "base/macros.h"

10 #include "base/memory/ptr_util.h"	10 #include "base/memory/ptr_util.h"

(...skipping 310 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
321 base::Bind(&ClearBrowsingDataHandler::UpdateCounterText,	321 base::Bind(&ClearBrowsingDataHandler::UpdateCounterText,

322 base::Unretained(this)));	322 base::Unretained(this)));

323 counters_.push_back(std::move(counter));	323 counters_.push_back(std::move(counter));

324 }	324 }

325	325

326 void ClearBrowsingDataHandler::UpdateCounterText(	326 void ClearBrowsingDataHandler::UpdateCounterText(

327 std::unique_ptr<browsing_data::BrowsingDataCounter::Result> result) {	327 std::unique_ptr<browsing_data::BrowsingDataCounter::Result> result) {

328 CallJavascriptFunction(	328 CallJavascriptFunction(

329 "cr.webUIListenerCallback", base::Value("update-counter-text"),	329 "cr.webUIListenerCallback", base::Value("update-counter-text"),

330 base::Value(result->source()->GetPrefName()),	330 base::Value(result->source()->GetPrefName()),

331 base::Value(GetChromeCounterTextFromResult(result.get())));	331 base::Value(GetChromeCounterTextFromResult(

	332 result.get(), browsing_data::ClearBrowsingDataTab::ADVANCED)));

332 }	333 }

333	334

334 } // namespace settings	335 } // namespace settings

OLD	NEW