Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Unified Diff: storage/browser/BUILD.gn

Issue 2730703002: DEPS: Update leveldatabase from 1.18 to 1.20. (Closed)
Patch Set: Suppress Visual Studio 2012 warning in cache_test.cc. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | third_party/leveldatabase/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: storage/browser/BUILD.gn
diff --git a/storage/browser/BUILD.gn b/storage/browser/BUILD.gn
index d701ae0b049d505f83e479ada8802ebd1a570b83..aac83bfcfd29ab8a40c6519690b761f72dbf2916 100644
--- a/storage/browser/BUILD.gn
+++ b/storage/browser/BUILD.gn
@@ -237,4 +237,9 @@ test("storage_unittests") {
"//base/test:test_support",
"//testing/gtest",
]
+
+ # Trick for getting leveldb tests compiled on the CQ. http://crbug.com/697788
Nico 2017/03/02 14:11:27 dpranke: ^
Dirk Pranke 2017/03/02 16:35:00 Don't do this, it's making the build incorrect by
+ if (!is_android) {
+ deps += [ "//third_party/leveldatabase:leveldb_test_targets" ]
+ }
}
« no previous file with comments | « DEPS ('k') | third_party/leveldatabase/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698