Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: runtime/vm/flow_graph_optimizer.h

Issue 27307005: Change == into an instance call to allow polymorphic inlining of ==. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: rebased, addressed comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_optimizer.h
===================================================================
--- runtime/vm/flow_graph_optimizer.h (revision 29797)
+++ runtime/vm/flow_graph_optimizer.h (working copy)
@@ -58,8 +58,6 @@
virtual void VisitStaticCall(StaticCallInstr* instr);
virtual void VisitInstanceCall(InstanceCallInstr* instr);
- virtual void VisitEqualityCompare(EqualityCompareInstr* instr);
- virtual void VisitBranch(BranchInstr* instr);
void InsertBefore(Instruction* next,
Instruction* instr,
@@ -101,6 +99,7 @@
bool TryReplaceWithBinaryOp(InstanceCallInstr* call, Token::Kind op_kind);
bool TryReplaceWithUnaryOp(InstanceCallInstr* call, Token::Kind op_kind);
+ bool TryReplaceWithEqualityOp(InstanceCallInstr* call, Token::Kind op_kind);
bool TryReplaceWithRelationalOp(InstanceCallInstr* call, Token::Kind op_kind);
bool TryInlineInstanceGetter(InstanceCallInstr* call);
@@ -201,23 +200,6 @@
void ReplaceWithMathCFunction(InstanceCallInstr* call,
MethodRecognizer::Kind recognized_kind);
- // Visit an equality compare. The current instruction can be the
- // comparison itself or a branch on the comparison.
- template <typename T>
- void HandleEqualityCompare(EqualityCompareInstr* comp,
- T current_instruction);
-
- static bool CanStrictifyEqualityCompare(EqualityCompareInstr* call);
-
- template <typename T>
- bool StrictifyEqualityCompare(EqualityCompareInstr* compare,
- T current_instruction) const;
-
- template <typename T>
- bool StrictifyEqualityCompareWithICData(EqualityCompareInstr* compare,
- const ICData& unary_ic_data,
- T current_instruction);
-
void OptimizeLeftShiftBitAndSmiOp(Definition* bit_and_instr,
Definition* left_instr,
Definition* right_instr);
« no previous file with comments | « runtime/vm/flow_graph_inliner.cc ('k') | runtime/vm/flow_graph_optimizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698