Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: runtime/vm/flow_graph_inliner.cc

Issue 27307005: Change == into an instance call to allow polymorphic inlining of ==. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: rebased, addressed comments Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_optimizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_inliner.cc
===================================================================
--- runtime/vm/flow_graph_inliner.cc (revision 29797)
+++ runtime/vm/flow_graph_inliner.cc (working copy)
@@ -171,11 +171,23 @@
++instruction_count_;
Instruction* current = it.Current();
if (current->IsStaticCall() ||
- current->IsClosureCall() ||
- (current->IsPolymorphicInstanceCall() &&
- !current->AsPolymorphicInstanceCall()->HasRecognizedTarget())) {
+ current->IsClosureCall()) {
++call_site_count_;
+ continue;
}
+ if (current->IsPolymorphicInstanceCall()) {
+ PolymorphicInstanceCallInstr* call =
+ current->AsPolymorphicInstanceCall();
+ // These checks make sure that the number of call-sites counted does
+ // not change relative to the time when the current set of inlining
+ // parameters was fixed.
+ // TODO(fschneider): Determine new heuristic parameters that avoid
+ // these checks entirely.
+ if (!call->HasRecognizedTarget() &&
+ (call->instance_call()->token_kind() != Token::kEQ)) {
+ ++call_site_count_;
+ }
+ }
}
}
}
« no previous file with comments | « runtime/vm/flow_graph_compiler.cc ('k') | runtime/vm/flow_graph_optimizer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698