Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 2730673003: blink_gc_plugin: always enable warn_stack_allocated_trace_method check. (Closed)
Patch Set: retire GC option flag also Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
index 099b2bd96bdd4f2ad0fbaa71b28bd2fd26ea046f..43b064ccdcf3f2068f7633de2aa1c51212cb0af8 100644
--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
@@ -34,7 +34,9 @@ class BlinkGCPluginAction : public PluginASTAction {
if (arg == "dump-graph") {
options_.dump_graph = true;
} else if (arg == "warn-stack-allocated-trace-method") {
- options_.warn_stack_allocated_trace_method = true;
+ // TODO(sof): after next roll, remove this option to round out
+ // crbug.com/689874
+ continue;
} else if (arg == "warn-unneeded-finalizer") {
options_.warn_unneeded_finalizer = true;
} else if (arg == "use-chromium-style-naming") {
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginConsumer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698