Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp

Issue 2730673003: blink_gc_plugin: always enable warn_stack_allocated_trace_method check. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
diff --git a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
index 099b2bd96bdd4f2ad0fbaa71b28bd2fd26ea046f..5063e69e0b896272cc8e36c9acc9ecc8f6053484 100644
--- a/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
+++ b/tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
@@ -34,6 +34,8 @@ class BlinkGCPluginAction : public PluginASTAction {
if (arg == "dump-graph") {
options_.dump_graph = true;
} else if (arg == "warn-stack-allocated-trace-method") {
+ // TODO(sof): will be removed once a GC plugin binary has been rolled
+ // out with a |true| default for warn_stack_allocated_trace_method.
options_.warn_stack_allocated_trace_method = true;
} else if (arg == "warn-unneeded-finalizer") {
options_.warn_unneeded_finalizer = true;
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h » ('j') | tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698