Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(184)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h
Issue
2730673003
:
blink_gc_plugin: always enable warn_stack_allocated_trace_method check. (Closed)
Patch Set:
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp
tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h
tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.h
tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.cpp
tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.txt
tools/clang/blink_gc_plugin/tests/stack_allocated_no_warning.h
tools/clang/blink_gc_plugin/tests/stack_allocated_no_warning.cpp
tools/clang/blink_gc_plugin/tests/stack_allocated_no_warning.txt
View unified diff
|
Download patch
« tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h
('K') |
« tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h
('k') |
tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.cpp »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2017 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#ifndef STACK_ALLOCATED_H_
6
#define STACK_ALLOCATED_H_
7
8
#include "heap/stubs.h"
9
10
namespace blink {
11
12
class HeapObject;
13
14
class StackObject {
15
STACK_ALLOCATED();
16
17
// Redundant trace() method, but warning/error disabled.
18
void trace(Visitor* visitor) { visitor->trace(m_obj); }
19
20
private:
21
Member<HeapObject> m_obj; // Does not need tracing.
22
};
23
24
}
25
26
#endif
OLD
NEW
« tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h
('K') |
« tools/clang/blink_gc_plugin/BlinkGCPluginOptions.h
('k') |
tools/clang/blink_gc_plugin/tests/legacy_naming/stack_allocated_no_warning.cpp »
('j') |
no next file with comments »
Issue 2730673003: blink_gc_plugin: always enable warn_stack_allocated_trace_method check. (Closed)
Created 3 years, 9 months ago by sof
Modified 3 years, 9 months ago
Reviewers: oilpan-reviews, Nico
Base URL:
Comments: 3
This is Rietveld
408576698