Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: components/spellcheck/renderer/spellcheck_unittest.cc

Issue 2730663003: [spellcheck] Narrowly re-enabled some unit tests for Windows (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/spellcheck/renderer/spellcheck_unittest.cc
diff --git a/components/spellcheck/renderer/spellcheck_unittest.cc b/components/spellcheck/renderer/spellcheck_unittest.cc
index 2a1dc3e118c1be5ec0d91f5ea4869775df317803..83358f369655c443a8e71271c4bf0dc327b33a16 100644
--- a/components/spellcheck/renderer/spellcheck_unittest.cc
+++ b/components/spellcheck/renderer/spellcheck_unittest.cc
@@ -490,14 +490,7 @@ TEST_F(SpellCheckTest, SpellCheckSuggestions_EN_US) {
// This test verifies our spellchecker can split a text into words and check
// the spelling of each word in the text.
-#if defined(OS_WIN)
-// SpellCheckTest.SpellCheckText fails on Windows.
-// See http://crbug.com/689101.
-#define MAYBE_SpellCheckText DISABLED_SpellCheckText
-#else
-#define MAYBE_SpellCheckText SpellCheckText
-#endif // OS_WIN
-TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
+TEST_F(SpellCheckTest, SpellCheckText) {
static const struct {
const char* language;
const wchar_t* input;
@@ -634,6 +627,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
L"\x092E\x0947\x0902 \x0914\x0930 \x0909\x092A\x092F\x094B\x0917\x0940 "
L"\x092C\x0928\x093E\x0928\x093E \x0939\x0948."
}, {
+#if !defined(OS_WIN)
// Hungarian
"hu-HU",
L"A Google azt a k\x00FCldet\x00E9st v\x00E1llalta mag\x00E1ra, "
@@ -641,6 +635,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
L"rendszerezze \x00E9s \x00E1ltal\x00E1nosan el\x00E9rhet\x0151v\x00E9, "
L"illetve haszn\x00E1lhat\x00F3v\x00E1 tegye."
}, {
+#endif // !defined(OS_WIN)
// Croatian
"hr-HR",
// L"Googleova " - to be added.
@@ -686,6 +681,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
L"zasob\x00F3w informacji, aby sta\x0142y si\x0119 one powszechnie "
L"dost\x0119pne i u\x017Cyteczne."
}, {
+#if !defined(OS_WIN)
// Portuguese (Brazil)
"pt-BR",
L"A miss\x00E3o do "
@@ -699,6 +695,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
#endif
L"acess\x00EDveis e \x00FAteis em car\x00E1ter universal."
}, {
+#endif // !defined(OS_WIN)
// Portuguese (Portugal)
"pt-PT",
L"O "
@@ -768,6 +765,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
L"Googles m\x00E5ls\x00E4ttning \x00E4r att ordna v\x00E4rldens "
L"samlade information och g\x00F6ra den tillg\x00E4nglig f\x00F6r alla."
}, {
+#if !defined(OS_WIN)
// Turkish
"tr-TR",
// L"Google\x2019\x0131n " - to be added.
@@ -775,6 +773,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
L"organize etmek ve evrensel olarak eri\x015Filebilir ve "
L"kullan\x0131\x015Fl\x0131 k\x0131lmakt\x0131r."
}, {
+#endif // !defined(OS_WIN)
// Ukranian
"uk-UA",
L"\x041c\x0456\x0441\x0456\x044f "
@@ -798,6 +797,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
L"th\x1EBF gi\x1EDBi va l\x00E0m cho n\x00F3 universal c\x00F3 "
L"th\x1EC3 truy c\x1EADp va h\x1EEFu d\x1EE5ng h\x01A1n."
}, {
+#if !defined(OS_WIN)
// Korean
"ko",
L"Google\xC758 \xBAA9\xD45C\xB294 \xC804\xC138\xACC4\xC758 "
@@ -805,6 +805,7 @@ TEST_F(SpellCheckTest, MAYBE_SpellCheckText) {
L"\xD3B8\xB9AC\xD558\xAC8C \xC774\xC6A9\xD560 \xC218 "
L"\xC788\xB3C4\xB85D \xD558\xB294 \xAC83\xC785\xB2C8\xB2E4."
}, {
+#endif // !defined(OS_WIN)
// Albanian
"sq",
L"Misioni i Google \x00EBsht\x00EB q\x00EB t\x00EB organizoj\x00EB "
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698