Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: net/ssl/ssl_config_service_unittest.cc

Issue 2730623005: Make SSLConfigManager notify clients if the SHA-1 policy changes (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ssl/ssl_config_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ssl/ssl_config_service_unittest.cc
diff --git a/net/ssl/ssl_config_service_unittest.cc b/net/ssl/ssl_config_service_unittest.cc
index 11f59cd82415094e44b1e5eb0a4b279d7698d22a..72041ff2412858d4cbee0e0aa868314ce17fe20d 100644
--- a/net/ssl/ssl_config_service_unittest.cc
+++ b/net/ssl/ssl_config_service_unittest.cc
@@ -65,7 +65,10 @@ TEST(SSLConfigServiceTest, NoChangesWontNotifyObservers) {
TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {
SSLConfig initial_config;
initial_config.rev_checking_enabled = true;
+ initial_config.rev_checking_required_local_anchors = false;
+ initial_config.sha1_local_anchors_enabled = true;
initial_config.false_start_enabled = false;
+ initial_config.require_ecdhe = false;
initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1;
initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_2;
@@ -79,10 +82,22 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {
EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
mock_service->SetSSLConfig(initial_config);
+ initial_config.rev_checking_required_local_anchors = true;
+ EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
+ mock_service->SetSSLConfig(initial_config);
+
+ initial_config.sha1_local_anchors_enabled = false;
+ EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
+ mock_service->SetSSLConfig(initial_config);
+
initial_config.false_start_enabled = true;
EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
mock_service->SetSSLConfig(initial_config);
+ initial_config.require_ecdhe = true;
+ EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
+ mock_service->SetSSLConfig(initial_config);
+
// Test that changing the SSL version range triggers updates.
initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1_1;
EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
« no previous file with comments | « net/ssl/ssl_config_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698