Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Side by Side Diff: src/debug/debug-evaluate.cc

Issue 2730573004: Revert of Migrate Object.prototype.valueOf to CSA (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/builtins/builtins-object.cc ('k') | src/js/v8natives.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug-evaluate.h" 5 #include "src/debug/debug-evaluate.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/contexts.h" 9 #include "src/contexts.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 !frame_->receiver()->IsTheHole(isolate_)) { 254 !frame_->receiver()->IsTheHole(isolate_)) {
255 recv = handle(frame_->receiver(), isolate_); 255 recv = handle(frame_->receiver(), isolate_);
256 } 256 }
257 JSObject::SetOwnPropertyIgnoreAttributes(target, name, recv, NONE).Check(); 257 JSObject::SetOwnPropertyIgnoreAttributes(target, name, recv, NONE).Check();
258 } 258 }
259 259
260 namespace { 260 namespace {
261 261
262 bool IntrinsicHasNoSideEffect(Runtime::FunctionId id) { 262 bool IntrinsicHasNoSideEffect(Runtime::FunctionId id) {
263 switch (id) { 263 switch (id) {
264 // Whitelist for intrinsics and runtime functions. 264 // Whitelist for intrinsics amd runtime functions.
265 // Conversions. 265 // Conversions.
266 case Runtime::kToInteger: 266 case Runtime::kToInteger:
267 case Runtime::kInlineToInteger: 267 case Runtime::kInlineToInteger:
268 case Runtime::kToObject: 268 case Runtime::kToObject:
269 case Runtime::kInlineToObject: 269 case Runtime::kInlineToObject:
270 case Runtime::kToString: 270 case Runtime::kToString:
271 case Runtime::kInlineToString: 271 case Runtime::kInlineToString:
272 case Runtime::kToLength: 272 case Runtime::kToLength:
273 case Runtime::kInlineToLength: 273 case Runtime::kInlineToLength:
274 case Runtime::kToNumber: 274 case Runtime::kToNumber:
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
398 PrintF("[debug-evaluate] bytecode %s may cause side effect.\n", 398 PrintF("[debug-evaluate] bytecode %s may cause side effect.\n",
399 Bytecodes::ToString(bytecode)); 399 Bytecodes::ToString(bytecode));
400 } 400 }
401 return false; 401 return false;
402 } 402 }
403 } 403 }
404 404
405 bool BuiltinHasNoSideEffect(Builtins::Name id) { 405 bool BuiltinHasNoSideEffect(Builtins::Name id) {
406 switch (id) { 406 switch (id) {
407 // Whitelist for builtins. 407 // Whitelist for builtins.
408 // Object builtins.
409 case Builtins::kObjectPrototypeValueOf:
410 // Array builtins. 408 // Array builtins.
411 case Builtins::kArrayCode: 409 case Builtins::kArrayCode:
412 case Builtins::kArrayIndexOf: 410 case Builtins::kArrayIndexOf:
413 case Builtins::kArrayPrototypeValues: 411 case Builtins::kArrayPrototypeValues:
414 case Builtins::kArrayIncludes: 412 case Builtins::kArrayIncludes:
415 case Builtins::kArrayPrototypeEntries: 413 case Builtins::kArrayPrototypeEntries:
416 case Builtins::kArrayPrototypeKeys: 414 case Builtins::kArrayPrototypeKeys:
417 case Builtins::kArrayForEach: 415 case Builtins::kArrayForEach:
418 // Math builtins. 416 // Math builtins.
419 case Builtins::kMathAbs: 417 case Builtins::kMathAbs:
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 560
563 if (FLAG_trace_side_effect_free_debug_evaluate) { 561 if (FLAG_trace_side_effect_free_debug_evaluate) {
564 PrintF("[debug-evaluate] API Callback at %p may cause side effect.\n", 562 PrintF("[debug-evaluate] API Callback at %p may cause side effect.\n",
565 reinterpret_cast<void*>(function_addr)); 563 reinterpret_cast<void*>(function_addr));
566 } 564 }
567 return false; 565 return false;
568 } 566 }
569 567
570 } // namespace internal 568 } // namespace internal
571 } // namespace v8 569 } // namespace v8
OLDNEW
« no previous file with comments | « src/builtins/builtins-object.cc ('k') | src/js/v8natives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698