third_party/WebKit/Source/web/WebLocalFrameImpl.cpp - Issue 2730573003: Moved FrameHost::m_visualViewport to Page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2730573003: Moved FrameHost::m_visualViewport to Page (Closed)

Patch Set: Fixed some compile errors on mac and android Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

index 4deb1c6ba3876fe687a5581c750d90514e753607..3098588d80705f72cc454d4775fd9c4706b4ab3a 100644

--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

@@ -1920,7 +1920,7 @@ void WebLocalFrameImpl::loadJavaScriptURL(const KURL& url) {

HitTestResult WebLocalFrameImpl::hitTestResultForVisualViewportPos(

const IntPoint& posInViewport) {

IntPoint rootFramePoint(

- frame()->host()->visualViewport().viewportToRootFrame(posInViewport));

+ frame()->page()->visualViewport().viewportToRootFrame(posInViewport));

IntPoint docPoint(frame()->view()->rootFrameToContents(rootFramePoint));

HitTestResult result = frame()->eventHandler().hitTestResultAtPoint(

docPoint, HitTestRequest::ReadOnly | HitTestRequest::Active);