Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: components/content_settings/core/common/content_settings_pattern_unittest.cc

Issue 2730533002: chrome.contentSettings API: Block patterns that match extension URLs for mic and video
Patch Set: Fix MatchesExtensionUrls Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings/core/common/content_settings_pattern.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/content_settings/core/common/content_settings_pattern_unittest.cc
diff --git a/components/content_settings/core/common/content_settings_pattern_unittest.cc b/components/content_settings/core/common/content_settings_pattern_unittest.cc
index d5aab80ab86a3d0d69fde5eef8acd91633b49729..9e6a950652d3921c86bd1e3957b23c7866631357 100644
--- a/components/content_settings/core/common/content_settings_pattern_unittest.cc
+++ b/components/content_settings/core/common/content_settings_pattern_unittest.cc
@@ -317,6 +317,22 @@ TEST(ContentSettingsPatternTest, FromString_FilePatterns) {
pattern.Compare(file_wildcard));
}
+TEST(ContentSettingsPatternTest, FromString_MatchesExtensionUrls) {
+ EXPECT_TRUE(Pattern("chrome-extension://peoadpeiejnhkmpaakpnompolbglelel/")
+ .MatchesExtensionUrls());
+ EXPECT_FALSE(
+ Pattern("chrome-extension://peoadpeiejnhkmpaakpnompolbglelelaaaa/")
+ .MatchesExtensionUrls());
+
+ EXPECT_TRUE(
+ Pattern("*://peoadpeiejnhkmpaakpnompolbglelel/").MatchesExtensionUrls());
+ EXPECT_TRUE(Pattern("*://*/").MatchesExtensionUrls());
+
+ EXPECT_FALSE(Pattern("*://[*.]aaaa/").MatchesExtensionUrls());
+ EXPECT_FALSE(Pattern("*://peoadpeiejnhkmpaakpnompolbglelelaaaa/")
+ .MatchesExtensionUrls());
+}
+
TEST(ContentSettingsPatternTest, FromString_ExtensionPatterns) {
EXPECT_TRUE(Pattern("chrome-extension://peoadpeiejnhkmpaakpnompolbglelel/")
.IsValid());
« no previous file with comments | « components/content_settings/core/common/content_settings_pattern.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698