Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9669)

Unified Diff: chrome/renderer/extensions/extension_api_client_unittest.cc

Issue 273048: Allow extensions to pin tabs:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_api_client_unittest.cc
===================================================================
--- chrome/renderer/extensions/extension_api_client_unittest.cc (revision 28937)
+++ chrome/renderer/extensions/extension_api_client_unittest.cc (working copy)
@@ -383,18 +383,22 @@
ExpectJsFail("chrome.tabs.update(42, {selected: 'foo'});",
"Uncaught Error: Invalid value for argument 1. Property "
"'selected': Expected 'boolean' but got 'string'.");
+ ExpectJsFail("chrome.tabs.update(42, {pinned: 'foo'});",
Aaron Boodman 2010/10/14 18:04:17 We don't really use this class anymore. We should
+ "Uncaught Error: Invalid value for argument 1. Property "
+ "'pinned': Expected 'boolean' but got 'string'.");
ExpectJsFail("chrome.tabs.update(42, {url: 42});",
"Uncaught Error: Invalid value for argument 1. Property "
"'url': Expected 'string' but got 'integer'.");
ExpectJsPass("chrome.tabs.update(42, {"
" url:'http://www.google.com/',"
- " selected:true"
+ " selected:true,"
+ " pinned:false"
"})",
"tabs.update",
"[42,"
"{\"url\":\"http://www.google.com/\","
- "\"selected\":true}]");
+ "\"selected\":true,\"pinned\":false}]");
}
TEST_F(ExtensionAPIClientTest, MoveTab) {

Powered by Google App Engine
This is Rietveld 408576698