Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 2730473002: Build addr2line-pdb from tcmalloc for use in memory-infra symbolization (Closed)
Patch Set: make it all work Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/tcmalloc/BUILD.gn » ('j') | third_party/tcmalloc/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 1c9bb954acc172fdc2c56d5fd2b2375273cbb6ae..48d66174762b1263447b301967f3e3894ac9c04b 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -673,6 +673,7 @@ group("both_gn_and_gyp") {
"//sandbox/win:sbox_validation_tests",
"//testing/gtest:gtest_main",
"//third_party/pdfium/samples:pdfium_diff",
+ "//third_party/tcmalloc:addr2line-pdb",
erikchen 2017/03/01 22:42:51 gyp is deprecated, maybe move this to gn_only?
awong 2017/03/01 22:57:00 Done.
"//tools/win/chromeexts:chromeexts",
]
deps -= [
« no previous file with comments | « no previous file | third_party/tcmalloc/BUILD.gn » ('j') | third_party/tcmalloc/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698