Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2730453003: Clean up language_kernel.status. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -1983 lines) Patch
M tests/language/language_kernel.status View 28 chunks +181 lines, -1983 lines 1 comment Download

Dependent Patchsets:

Issue 2725143002 Patch 1

Messages

Total messages: 6 (2 generated)
ahe
3 years, 9 months ago (2017-03-02 10:48:21 UTC) #2
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/2730453003/diff/1/tests/language/language_kernel.status File tests/language/language_kernel.status (left): https://codereview.chromium.org/2730453003/diff/1/tests/language/language_kernel.status#oldcode697 tests/language/language_kernel.status:697: ############################################################################### You're my hero.
3 years, 9 months ago (2017-03-02 10:50:02 UTC) #3
Vyacheslav Egorov (Google)
Sticks the value! LGTM
3 years, 9 months ago (2017-03-02 10:51:41 UTC) #4
ahe
3 years, 9 months ago (2017-03-02 10:59:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
501c0e7c452b2e93f18801ec6819824dc9764e6b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698