Source/core/rendering/RenderView.cpp - Issue 273043002: Don't use pageLogicalHeight() to resolve percentage values in subframes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderView.cpp

Issue 273043002: Don't use pageLogicalHeight() to resolve percentage values in subframes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@mixed-case-selector

Patch Set: Set a fixed body height to work around rounding issue on mac; also add a title to the test to descr… Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderView.cpp

diff --git a/Source/core/rendering/RenderView.cpp b/Source/core/rendering/RenderView.cpp

index 68db6300b10aefcaf2e363854282cc26ef58b149..d7d3b7b7eec0e004c114ec3893663289d67c91f8 100644

--- a/Source/core/rendering/RenderView.cpp

+++ b/Source/core/rendering/RenderView.cpp

@@ -840,6 +840,13 @@ int RenderView::viewLogicalHeight() const

return style()->isHorizontalWritingMode() ? viewHeight(ExcludeScrollbars) : viewWidth(ExcludeScrollbars);

}

+LayoutUnit RenderView::viewLogicalHeightForPercentages() const

+ if (shouldUsePrintingLayout())

+ return pageLogicalHeight();

+ return viewLogicalHeight();

float RenderView::zoomFactor() const

{

return m_frameView->frame().pageZoomFactor();

« no previous file with comments | « Source/core/rendering/RenderView.h ('k') | no next file » | no next file with comments »