Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Side by Side Diff: Source/core/rendering/RenderView.h

Issue 273043002: Don't use pageLogicalHeight() to resolve percentage values in subframes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@mixed-case-selector
Patch Set: Set a fixed body height to work around rounding issue on mac; also add a title to the test to descr… Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2006 Apple Computer, Inc. 3 * Copyright (C) 2006 Apple Computer, Inc.
4 * 4 *
5 * This library is free software; you can redistribute it and/or 5 * This library is free software; you can redistribute it and/or
6 * modify it under the terms of the GNU Library General Public 6 * modify it under the terms of the GNU Library General Public
7 * License as published by the Free Software Foundation; either 7 * License as published by the Free Software Foundation; either
8 * version 2 of the License, or (at your option) any later version. 8 * version 2 of the License, or (at your option) any later version.
9 * 9 *
10 * This library is distributed in the hope that it will be useful, 10 * This library is distributed in the hope that it will be useful,
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 virtual LayoutUnit availableLogicalHeight(AvailableLogicalHeightType) const OVERRIDE; 62 virtual LayoutUnit availableLogicalHeight(AvailableLogicalHeightType) const OVERRIDE;
63 63
64 // The same as the FrameView's layoutHeight/layoutWidth but with null check guards. 64 // The same as the FrameView's layoutHeight/layoutWidth but with null check guards.
65 int viewHeight(IncludeScrollbarsInRect = ExcludeScrollbars) const; 65 int viewHeight(IncludeScrollbarsInRect = ExcludeScrollbars) const;
66 int viewWidth(IncludeScrollbarsInRect = ExcludeScrollbars) const; 66 int viewWidth(IncludeScrollbarsInRect = ExcludeScrollbars) const;
67 int viewLogicalWidth() const 67 int viewLogicalWidth() const
68 { 68 {
69 return style()->isHorizontalWritingMode() ? viewWidth(ExcludeScrollbars) : viewHeight(ExcludeScrollbars); 69 return style()->isHorizontalWritingMode() ? viewWidth(ExcludeScrollbars) : viewHeight(ExcludeScrollbars);
70 } 70 }
71 int viewLogicalHeight() const; 71 int viewLogicalHeight() const;
72 LayoutUnit viewLogicalHeightForPercentages() const;
72 73
73 float zoomFactor() const; 74 float zoomFactor() const;
74 75
75 FrameView* frameView() const { return m_frameView; } 76 FrameView* frameView() const { return m_frameView; }
76 77
77 virtual void computeRectForRepaint(const RenderLayerModelObject* repaintCont ainer, LayoutRect&, bool fixed = false) const OVERRIDE; 78 virtual void computeRectForRepaint(const RenderLayerModelObject* repaintCont ainer, LayoutRect&, bool fixed = false) const OVERRIDE;
78 void repaintViewRectangle(const LayoutRect&) const; 79 void repaintViewRectangle(const LayoutRect&) const;
79 80
80 void repaintViewAndCompositedLayers(); 81 void repaintViewAndCompositedLayers();
81 82
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 { 374 {
374 m_view.enableLayoutState(); 375 m_view.enableLayoutState();
375 } 376 }
376 private: 377 private:
377 RenderView& m_view; 378 RenderView& m_view;
378 }; 379 };
379 380
380 } // namespace WebCore 381 } // namespace WebCore
381 382
382 #endif // RenderView_h 383 #endif // RenderView_h
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698