Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issue 2730413003: Remove non-standard API SVGStyleElement#disabled (Closed)

Created:
3 years, 9 months ago by riju_
Modified:
3 years, 7 months ago
Reviewers:
Stephen Chennney, fs, foolip
CC:
chromium-reviews, krit, blink-reviews-style_chromium.org, rwlbuis, fmalita+watch_chromium.org, blink-reviews, gyuyoung2, Stephen Chennney, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-standard API SVGStyleElement#disabled It has been removed from the spec. Neither Gecko and WebKit has it. BUG=695984

Patch Set 1 #

Patch Set 2 : Remove Layout tests for SVGStyleElement#disabled #

Patch Set 3 : Fix webexposed in Layout tests #

Messages

Total messages: 23 (19 generated)
riju_
@foolip : I removed a TODO(foolip), so PTAL
3 years, 9 months ago (2017-03-08 15:29:55 UTC) #19
fs
The "We should just remove this API" feels a bit out of place in the ...
3 years, 9 months ago (2017-03-08 15:44:46 UTC) #20
riju_
On 2017/03/08 15:44:46, fs wrote: > The "We should just remove this API" feels a ...
3 years, 9 months ago (2017-03-08 15:54:59 UTC) #22
foolip
3 years, 9 months ago (2017-03-09 02:06:49 UTC) #23
I think this should have an Intent to Remove and I've commented on
https://bugs.chromium.org/p/chromium/issues/detail?id=695984#c5 about the things
I think need to be investigated. I'd be happy to help out poking around if
there's something that seems weird.

Powered by Google App Engine
This is Rietveld 408576698