buildbot/README.google - Issue 273040: Make "Slave lost" purple (exception) instead of red (failure).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: buildbot/README.google

Issue 273040: Make "Slave lost" purple (exception) instead of red (failure). (Closed) Base URL: svn://chrome-svn.corp.google.com/chrome/trunk/tools/buildbot/pylibs/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: buildbot/README.google

===================================================================

--- buildbot/README.google (revision 28679)

+++ buildbot/README.google (working copy)

@@ -12,6 +12,7 @@

process/buildstep.py

Add **kwargs at the end of the __init__ for RemoteShellCommand since

we pass more parameters.

+ Change "slave lost" to be an exception instead of a failure.

slave/commands.py

Use os.path.normpath when calling os.makedirs when it might be called with

« no previous file with comments | « no previous file | buildbot/process/buildstep.py » ('j') | no next file with comments »