components/autofill/core/common/autofill_data_validation.cc - Issue 2730383003: Improve autofill form matching.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/autofill_data_validation.cc

Issue 2730383003: Improve autofill form matching. (Closed)

Patch Set: Move DetermineHeuristicTypes after the add. Rebase. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/common/autofill_data_validation.cc

diff --git a/components/autofill/core/common/autofill_data_validation.cc b/components/autofill/core/common/autofill_data_validation.cc

index 07c2b9dc9dbb424699af98c2d3b7d79cfcd8c063..f1075dc384d2040708c467e6db915ecf302009b0 100644

--- a/components/autofill/core/common/autofill_data_validation.cc

+++ b/components/autofill/core/common/autofill_data_validation.cc

@@ -35,7 +35,6 @@ bool IsValidFormFieldData(const FormFieldData& field) {

IsValidString16(field.value) &&

IsValidString(field.form_control_type) &&

IsValidString(field.autocomplete_attribute) &&

- IsValidString16Vector(field.option_values) &&

IsValidString16Vector(field.option_contents);

}

« no previous file with comments | « components/autofill/core/browser/form_structure.cc ('k') | no next file » | no next file with comments »