Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 2730383003: Improve autofill form matching. (Closed)
Patch Set: Move DetermineHeuristicTypes after the add. Rebase. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 407
408 // Returns a list of values from the stored credit cards that match |type| and 408 // Returns a list of values from the stored credit cards that match |type| and
409 // the value of |field| and returns the labels of the matching credit cards. 409 // the value of |field| and returns the labels of the matching credit cards.
410 std::vector<Suggestion> GetCreditCardSuggestions( 410 std::vector<Suggestion> GetCreditCardSuggestions(
411 const FormFieldData& field, 411 const FormFieldData& field,
412 const AutofillType& type) const; 412 const AutofillType& type) const;
413 413
414 // Parses the forms using heuristic matching and querying the Autofill server. 414 // Parses the forms using heuristic matching and querying the Autofill server.
415 void ParseForms(const std::vector<FormData>& forms); 415 void ParseForms(const std::vector<FormData>& forms);
416 416
417 // Parses the form and adds it to |form_structures_|.
418 bool ParseForm(const FormData& form, FormStructure** parsed_form_structure);
419
417 // Imports the form data, submitted by the user, into |personal_data_|. 420 // Imports the form data, submitted by the user, into |personal_data_|.
418 void ImportFormData(const FormStructure& submitted_form); 421 void ImportFormData(const FormStructure& submitted_form);
419 422
420 // Logs |metric_name| with RAPPOR, for the specific form |source_url|. 423 // Logs |metric_name| with RAPPOR, for the specific form |source_url|.
421 void CollectRapportSample(const GURL& source_url, 424 void CollectRapportSample(const GURL& source_url,
422 const std::string& metric_name) const; 425 const std::string& metric_name) const;
423 426
424 // Examines |card| and the stored profiles and if a candidate set of profiles 427 // Examines |card| and the stored profiles and if a candidate set of profiles
425 // is found that matches the client-side validation rules, assigns the values 428 // is found that matches the client-side validation rules, assigns the values
426 // to |profiles|. If no valid set can be found, returns false, assigns the 429 // to |profiles|. If no valid set can be found, returns false, assigns the
(...skipping 193 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 623 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
621 OnLoadedServerPredictions_ResetManager); 624 OnLoadedServerPredictions_ResetManager);
622 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard); 625 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
623 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate); 626 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
624 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 627 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
625 }; 628 };
626 629
627 } // namespace autofill 630 } // namespace autofill
628 631
629 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 632 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698