Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Side by Side Diff: components/autofill/core/browser/autofill_manager.h

Issue 2730383003: Improve autofill form matching. (Closed)
Patch Set: Address review issues. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 5 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 6 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <map> 9 #include <map>
10 #include <memory> 10 #include <memory>
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 405
406 // Returns a list of values from the stored credit cards that match |type| and 406 // Returns a list of values from the stored credit cards that match |type| and
407 // the value of |field| and returns the labels of the matching credit cards. 407 // the value of |field| and returns the labels of the matching credit cards.
408 std::vector<Suggestion> GetCreditCardSuggestions( 408 std::vector<Suggestion> GetCreditCardSuggestions(
409 const FormFieldData& field, 409 const FormFieldData& field,
410 const AutofillType& type) const; 410 const AutofillType& type) const;
411 411
412 // Parses the forms using heuristic matching and querying the Autofill server. 412 // Parses the forms using heuristic matching and querying the Autofill server.
413 void ParseForms(const std::vector<FormData>& forms); 413 void ParseForms(const std::vector<FormData>& forms);
414 414
415 // Parses the form and adds it to |form_structures_|.
416 bool ParseForm(const FormData& form, FormStructure** parsed_form_structure);
417
415 // Imports the form data, submitted by the user, into |personal_data_|. 418 // Imports the form data, submitted by the user, into |personal_data_|.
416 void ImportFormData(const FormStructure& submitted_form); 419 void ImportFormData(const FormStructure& submitted_form);
417 420
418 // Logs |metric_name| with RAPPOR, for the specific form |source_url|. 421 // Logs |metric_name| with RAPPOR, for the specific form |source_url|.
419 void CollectRapportSample(const GURL& source_url, 422 void CollectRapportSample(const GURL& source_url,
420 const std::string& metric_name) const; 423 const std::string& metric_name) const;
421 424
422 // Examines |card| and the stored profiles and if a candidate set of profiles 425 // Examines |card| and the stored profiles and if a candidate set of profiles
423 // is found that matches the client-side validation rules, assigns the values 426 // is found that matches the client-side validation rules, assigns the values
424 // to |profiles|. If no valid set can be found, returns false, assigns the 427 // to |profiles|. If no valid set can be found, returns false, assigns the
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, 616 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest,
614 OnLoadedServerPredictions_ResetManager); 617 OnLoadedServerPredictions_ResetManager);
615 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard); 618 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, DontOfferToSavePaymentsCard);
616 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate); 619 FRIEND_TEST_ALL_PREFIXES(AutofillManagerTest, FillInUpdatedExpirationDate);
617 DISALLOW_COPY_AND_ASSIGN(AutofillManager); 620 DISALLOW_COPY_AND_ASSIGN(AutofillManager);
618 }; 621 };
619 622
620 } // namespace autofill 623 } // namespace autofill
621 624
622 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_ 625 #endif // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_MANAGER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698