Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(576)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Issue 2730343003: Fix overflow:overlay scrollbar width for paint. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
index 291ea69ec6a4b0d4fd5d516cae3f9155a72e388a..0ffab478808ad4c1568cbf4f56a5a8c287fc5a9a 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
@@ -506,7 +506,10 @@ IntSize PaintLayerScrollableArea::maximumScrollOffsetInt() const {
IntSize contentSize = contentsSize();
IntSize visibleSize =
- pixelSnappedIntRect(box().overflowClipRect(box().location())).size();
+ pixelSnappedIntRect(
+ box().overflowClipRect(box().location(),
+ IgnorePlatformAndCSSOverlayScrollbarSize))
+ .size();
Page* page = layoutBox()->document().page();
DCHECK(page);
@@ -1300,10 +1303,16 @@ int PaintLayerScrollableArea::verticalScrollbarWidth(
OverlayScrollbarClipBehavior overlayScrollbarClipBehavior) const {
if (!hasVerticalScrollbar())
return 0;
- if ((verticalScrollbar()->isOverlayScrollbar() ||
- box().style()->overflowY() == EOverflow::kOverlay) &&
- (overlayScrollbarClipBehavior == IgnoreOverlayScrollbarSize ||
- !verticalScrollbar()->shouldParticipateInHitTesting())) {
+ if (overlayScrollbarClipBehavior ==
+ IgnorePlatformAndCSSOverlayScrollbarSize &&
+ box().style()->overflowY() == EOverflow::kOverlay) {
+ return 0;
+ }
+ if ((overlayScrollbarClipBehavior == IgnorePlatformOverlayScrollbarSize ||
+ overlayScrollbarClipBehavior ==
+ IgnorePlatformAndCSSOverlayScrollbarSize ||
+ !verticalScrollbar()->shouldParticipateInHitTesting()) &&
+ verticalScrollbar()->isOverlayScrollbar()) {
return 0;
}
return verticalScrollbar()->scrollbarThickness();
@@ -1313,10 +1322,16 @@ int PaintLayerScrollableArea::horizontalScrollbarHeight(
OverlayScrollbarClipBehavior overlayScrollbarClipBehavior) const {
if (!hasHorizontalScrollbar())
return 0;
- if ((horizontalScrollbar()->isOverlayScrollbar() ||
- box().style()->overflowX() == EOverflow::kOverlay) &&
- (overlayScrollbarClipBehavior == IgnoreOverlayScrollbarSize ||
- !horizontalScrollbar()->shouldParticipateInHitTesting())) {
+ if (overlayScrollbarClipBehavior ==
+ IgnorePlatformAndCSSOverlayScrollbarSize &&
+ box().style()->overflowX() == EOverflow::kOverlay) {
+ return 0;
+ }
+ if ((overlayScrollbarClipBehavior == IgnorePlatformOverlayScrollbarSize ||
+ overlayScrollbarClipBehavior ==
+ IgnorePlatformAndCSSOverlayScrollbarSize ||
+ !horizontalScrollbar()->shouldParticipateInHitTesting()) &&
+ horizontalScrollbar()->isOverlayScrollbar()) {
return 0;
}
return horizontalScrollbar()->scrollbarThickness();

Powered by Google App Engine
This is Rietveld 408576698