Issue 2730293003: Fix for parsing 'rethrow' statement with Fasta.

Issue 2730293003: Fix for parsing 'rethrow' statement with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix for parsing 'rethrow' statement with Fasta. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/bf4dd380eadf0474c16ffb34f422b79ffa964231

Patch Set 1 #

Total comments: 1

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	pkg/analyzer/test/generated/parser_fasta_test.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
	M	pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart	View		1 chunk	+9 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

lgtm https://codereview.chromium.org/2730293003/diff/1/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart File pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart (right): https://codereview.chromium.org/2730293003/diff/1/pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart#newcode570 pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart:570: void endRethrowStatement(Token throwToken, Token endToken) { "throwToken" --> ...

3 years, 9 months ago (2017-03-06 19:47:28 UTC) #2

scheglov

3 years, 9 months ago (2017-03-07 00:50:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bf4dd380eadf0474c16ffb34f422b79ffa964231 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages