Issue 273023003: Mojo: Add test utils to go between a ScopedPlatformHandle and a ScopedFILE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 273023003: Mojo: Add test utils to go between a ScopedPlatformHandle and a ScopedFILE. (Closed)

Created:
6 years, 7 months ago by viettrungluu

Modified:
6 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mojo: Add test utils to go between a ScopedPlatformHandle and a ScopedFILE. (This is useful since Chromium's temporary file functions mostly spit out a FILE*.) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270121

Patch Set 1 #

Patch Set 2 : fix win #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -35 lines)			Patch
M	mojo/common/test/test_utils.h	View		2 chunks	+11 lines, -5 lines	0 comments	Download
M	mojo/common/test/test_utils_posix.cc	View		2 chunks	+15 lines, -1 line	0 comments	Download
M	mojo/common/test/test_utils_win.cc	View	1	2 chunks	+38 lines, -1 line	0 comments	Download
M	mojo/embedder/platform_channel_pair_posix_unittest.cc	View		6 chunks	+18 lines, -28 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

6 years, 7 months ago (2014-05-13 16:29:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r270121 (presubmit successful).

Expand Messages | Collapse Messages