Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 273023003: Mojo: Add test utils to go between a ScopedPlatformHandle and a ScopedFILE. (Closed)

Created:
6 years, 7 months ago by viettrungluu
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Mojo: Add test utils to go between a ScopedPlatformHandle and a ScopedFILE. (This is useful since Chromium's temporary file functions mostly spit out a FILE*.) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270121

Patch Set 1 #

Patch Set 2 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -35 lines) Patch
M mojo/common/test/test_utils.h View 2 chunks +11 lines, -5 lines 0 comments Download
M mojo/common/test/test_utils_posix.cc View 2 chunks +15 lines, -1 line 0 comments Download
M mojo/common/test/test_utils_win.cc View 1 2 chunks +38 lines, -1 line 0 comments Download
M mojo/embedder/platform_channel_pair_posix_unittest.cc View 6 chunks +18 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 7 months ago (2014-05-13 00:17:43 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-13 15:50:55 UTC) #2
viettrungluu
6 years, 7 months ago (2014-05-13 16:29:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r270121 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698