third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Remove unnecessary include Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexed.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

index 13d501853b1b8bf2c92f8dafcc6b708aa1fa2f39..1bd8cc42f09418fbecde4747588b91e9e13c54f4 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestException.cpp

@@ -12,6 +12,8 @@

#include "V8TestException.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/IDLTypes.h"

+#include "bindings/core/v8/NativeValueTraitsImpl.h"

#include "bindings/core/v8/V8DOMConfiguration.h"

#include "bindings/core/v8/V8ObjectConstructor.h"

#include "core/dom/Document.h"

@@ -83,7 +85,7 @@ static void constructor(const v8::FunctionCallbackInfo<v8::Value>& info) {

}

uint16_t argument;

- argument = toUInt16(info.GetIsolate(), info[0], NormalConversion, exceptionState);

+ argument = NativeValueTraits<IDLUnsignedShort>::nativeValue(info.GetIsolate(), info[0], exceptionState, NormalConversion);

if (exceptionState.hadException())

return;