third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Move specialization for SerializedScriptValue to the appropriate header Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.h ('k') | third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

index 6d3ada69ca43ad5dd32e64d6e6bd4a5bef31a452..49c48ba26b038c19e863367ac61d608eef36d7af 100644

--- a/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp

@@ -12,6 +12,8 @@

#include "V8TestInterfacePartial.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/IDLTypes.h"

+#include "bindings/core/v8/NativeValueTraitsImpl.h"

#include "bindings/core/v8/ScriptPromise.h"

#include "bindings/core/v8/ScriptState.h"

#include "bindings/core/v8/V8DOMConfiguration.h"

@@ -46,7 +48,7 @@ static void partial4LongAttributeAttributeSetter(v8::Local<v8::Value> v8Value, c

ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestInterface", "partial4LongAttribute");

// Prepare the value to be set.

- int32_t cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

+ int32_t cppValue = NativeValueTraits<IDLLong>::nativeValue(info.GetIsolate(), v8Value, exceptionState, NormalConversion);

if (exceptionState.hadException())

return;

@@ -61,7 +63,7 @@ static void partial4StaticLongAttributeAttributeSetter(v8::Local<v8::Value> v8Va

ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "TestInterface", "partial4StaticLongAttribute");

// Prepare the value to be set.

- int32_t cppValue = toInt32(info.GetIsolate(), v8Value, NormalConversion, exceptionState);

+ int32_t cppValue = NativeValueTraits<IDLLong>::nativeValue(info.GetIsolate(), v8Value, exceptionState, NormalConversion);

if (exceptionState.hadException())

return;