third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Move specialization for SerializedScriptValue to the appropriate header Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestSpecialOperations.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

index cee20bd3d8cf655af98392a0e30f2747ceb0a770..d0c61ba531b5f789571817ffc072b963948f876f 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestPermissiveDictionary.cpp

@@ -12,6 +12,8 @@

#include "V8TestPermissiveDictionary.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/IDLTypes.h"

+#include "bindings/core/v8/NativeValueTraitsImpl.h"

namespace blink {

@@ -38,7 +40,7 @@ void V8TestPermissiveDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Valu

if (booleanMemberValue.IsEmpty() || booleanMemberValue->IsUndefined()) {

// Do nothing.

} else {

- bool booleanMember = toBoolean(isolate, booleanMemberValue, exceptionState);

+ bool booleanMember = NativeValueTraits<IDLBoolean>::nativeValue(isolate, booleanMemberValue, exceptionState);

if (exceptionState.hadException())

return;

impl.setBooleanMember(booleanMember);