Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)
Patch Set: Move specialization for SerializedScriptValue to the appropriate header Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
index 76ceaaf85bb911f7e9dbcb6668abd2dbde32a370..8d2c199ec029503f98d6e87d8d81bb6092f646aa 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor2.cpp
@@ -13,6 +13,8 @@
#include "bindings/core/v8/Dictionary.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
#include "bindings/core/v8/V8DOMConfiguration.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
#include "bindings/core/v8/V8TestInterfaceEmpty.h"
@@ -75,7 +77,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info) {
return;
}
- dictionaryArg = Dictionary(info.GetIsolate(), info[0], exceptionState);
+ dictionaryArg = NativeValueTraits<Dictionary>::nativeValue(info.GetIsolate(), info[0], exceptionState);
if (exceptionState.hadException())
return;
@@ -121,7 +123,7 @@ static void constructor4(const v8::FunctionCallbackInfo<v8::Value>& info) {
return;
}
- longArg = toInt32(info.GetIsolate(), info[1], NormalConversion, exceptionState);
+ longArg = NativeValueTraits<IDLLong>::nativeValue(info.GetIsolate(), info[1], exceptionState, NormalConversion);
if (exceptionState.hadException())
return;
@@ -141,7 +143,7 @@ static void constructor4(const v8::FunctionCallbackInfo<v8::Value>& info) {
return;
}
- defaultUndefinedOptionalDictionaryArg = Dictionary(info.GetIsolate(), info[4], exceptionState);
+ defaultUndefinedOptionalDictionaryArg = NativeValueTraits<Dictionary>::nativeValue(info.GetIsolate(), info[4], exceptionState);
if (exceptionState.hadException())
return;
@@ -264,4 +266,8 @@ TestInterfaceConstructor2* V8TestInterfaceConstructor2::toImplWithTypeCheck(v8::
return hasInstance(value, isolate) ? toImpl(v8::Local<v8::Object>::Cast(value)) : nullptr;
}
+TestInterfaceConstructor2* NativeValueTraits<TestInterfaceConstructor2>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {
+ return V8TestInterfaceConstructor2::toImplWithTypeCheck(isolate, value);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698