Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)
Patch Set: Move specialization for SerializedScriptValue to the appropriate header Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
index 15e56f62142cc07fc41604e3ecb31674c533787a..1741b133599da5e7eb6d21e0537a8d89a7b2e914 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceConstructor.cpp
@@ -13,7 +13,9 @@
#include "bindings/core/v8/Dictionary.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/IDLTypes.h"
#include "bindings/core/v8/LongOrTestDictionary.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
#include "bindings/core/v8/V8DOMConfiguration.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
#include "bindings/core/v8/V8TestDictionary.h"
@@ -85,7 +87,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info) {
HeapVector<LongOrTestDictionary> sequenceLongOrTestDictionaryArg;
Dictionary optionalDictionaryArg;
TestInterfaceEmpty* optionalTestInterfaceEmptyArg;
- doubleArg = toRestrictedDouble(info.GetIsolate(), info[0], exceptionState);
+ doubleArg = NativeValueTraits<IDLDouble>::nativeValue(info.GetIsolate(), info[0], exceptionState);
if (exceptionState.hadException())
return;
@@ -105,7 +107,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info) {
return;
}
- dictionaryArg = Dictionary(info.GetIsolate(), info[3], exceptionState);
+ dictionaryArg = NativeValueTraits<Dictionary>::nativeValue(info.GetIsolate(), info[3], exceptionState);
if (exceptionState.hadException())
return;
@@ -126,7 +128,7 @@ static void constructor2(const v8::FunctionCallbackInfo<v8::Value>& info) {
return;
}
- optionalDictionaryArg = Dictionary(info.GetIsolate(), info[7], exceptionState);
+ optionalDictionaryArg = NativeValueTraits<Dictionary>::nativeValue(info.GetIsolate(), info[7], exceptionState);
if (exceptionState.hadException())
return;
@@ -411,4 +413,8 @@ TestInterfaceConstructor* V8TestInterfaceConstructor::toImplWithTypeCheck(v8::Is
return hasInstance(value, isolate) ? toImpl(v8::Local<v8::Object>::Cast(value)) : nullptr;
}
+TestInterfaceConstructor* NativeValueTraits<TestInterfaceConstructor>::nativeValue(v8::Isolate* isolate, v8::Local<v8::Value> value, ExceptionState& exceptionState) {
+ return V8TestInterfaceConstructor::toImplWithTypeCheck(isolate, value);
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698