Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)
Patch Set: Move specialization for SerializedScriptValue to the appropriate header Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
index 80309c820104ee975e20a18f54653fca46970f02..26716ef94fd92219e6c1c7d79308f677a44c6b32 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionaryDerived.cpp
@@ -12,6 +12,8 @@
#include "V8TestDictionaryDerived.h"
#include "bindings/core/v8/ExceptionState.h"
+#include "bindings/core/v8/IDLTypes.h"
+#include "bindings/core/v8/NativeValueTraitsImpl.h"
#include "bindings/core/v8/V8TestDictionary.h"
namespace blink {
@@ -73,7 +75,7 @@ void V8TestDictionaryDerivedImplementedAs::toImpl(v8::Isolate* isolate, v8::Loca
exceptionState.throwTypeError("required member requiredLongMember is undefined.");
return;
} else {
- int32_t requiredLongMember = toInt32(isolate, requiredLongMemberValue, NormalConversion, exceptionState);
+ int32_t requiredLongMember = NativeValueTraits<IDLLong>::nativeValue(isolate, requiredLongMemberValue, exceptionState, NormalConversion);
if (exceptionState.hadException())
return;
impl.setRequiredLongMember(requiredLongMember);

Powered by Google App Engine
This is Rietveld 408576698