third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Move specialization for SerializedScriptValue to the appropriate header Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/tests/results/core/V8TestConstants.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

index da84d23de361ecfc6172b39ebe990399bb54e502..0146d9f48b98de70b619dbca922269c69e8ad027 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestDictionary.h

@@ -12,6 +12,7 @@

#ifndef V8TestDictionary_h

#define V8TestDictionary_h

+#include "bindings/core/v8/NativeValueTraits.h"

#include "bindings/core/v8/ToV8.h"

#include "bindings/core/v8/V8Binding.h"

#include "bindings/tests/idls/core/TestDictionary.h"

@@ -40,8 +41,8 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, TestDictionary& i

}

template <>

-struct NativeValueTraits<TestDictionary> {

- static TestDictionary nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

+struct NativeValueTraits<TestDictionary> : public NativeValueTraitsBase<TestDictionary> {

+ CORE_EXPORT static TestDictionary nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

};

template <>