third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Move specialization for SerializedScriptValue to the appropriate header Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl b/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl

index 3681457ff617e2e3b26598259dc3fa4203869a66..59e14fdb5a2d80d719ab1651af2a2c76b345cbec 100644

--- a/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/dictionary_v8.h.tmpl

@@ -30,8 +30,8 @@ inline void v8SetReturnValue(const CallbackInfo& callbackInfo, {{cpp_class}}& im

}

template <>

-struct NativeValueTraits<{{cpp_class}}> {

- static {{cpp_class}} nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

+struct NativeValueTraits<{{cpp_class}}> : public NativeValueTraitsBase<{{cpp_class}}> {

+ {{exported}}static {{cpp_class}} nativeValue(v8::Isolate*, v8::Local<v8::Value>, ExceptionState&);

};

template <>