third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8BindingForIDLTypes.h ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceOriginTrialEnabled.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

index 2ce3bc81ed75532b11ea976cc482837890178dcc..def669b841fbc84008aab298e3ff94bafa007bb9 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNode.cpp

@@ -12,7 +12,9 @@

#include "V8TestInterfaceNode.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/IDLTypes.h"

#include "bindings/core/v8/V8AbstractEventListener.h"

+#include "bindings/core/v8/V8BindingForIDLTypes.h"

#include "bindings/core/v8/V8DOMConfiguration.h"

#include "bindings/core/v8/V8EventListenerHelper.h"

#include "bindings/core/v8/V8ObjectConstructor.h"

@@ -213,7 +215,7 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethod(con

v8SetReturnValueFast(info, impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg(), impl);

return;

}

- optionalBooleanArgument = toBoolean(info.GetIsolate(), info[0], exceptionState);

+ optionalBooleanArgument = NativeValueTraits<IDLBoolean>::nativeValue(info.GetIsolate(), info[0], exceptionState);

if (exceptionState.hadException())

return;

@@ -236,7 +238,7 @@ static void perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArgMethodForM

v8SetReturnValueForMainWorld(info, impl->perWorldBindingsTestInterfaceEmptyMethodOptionalBooleanArg());

return;

}

- optionalBooleanArgument = toBoolean(info.GetIsolate(), info[0], exceptionState);

+ optionalBooleanArgument = NativeValueTraits<IDLBoolean>::nativeValue(info.GetIsolate(), info[0], exceptionState);

if (exceptionState.hadException())

return;