third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8BindingForIDLTypes.h ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceGarbageCollected.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

index 4d353d835e4b7f853127b143b5286363cc8e5475..308496a99c3655edf12c76c3f73a495c73299b61 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor.cpp

@@ -12,6 +12,8 @@

#include "V8TestInterfaceNamedConstructor.h"

#include "bindings/core/v8/ExceptionState.h"

+#include "bindings/core/v8/IDLTypes.h"

+#include "bindings/core/v8/V8BindingForIDLTypes.h"

#include "bindings/core/v8/V8DOMConfiguration.h"

#include "bindings/core/v8/V8ObjectConstructor.h"

#include "core/dom/Document.h"

@@ -112,11 +114,11 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio

if (!stringArg.prepare())

return;

- defaultUndefinedOptionalBooleanArg = toBoolean(info.GetIsolate(), info[1], exceptionState);

+ defaultUndefinedOptionalBooleanArg = NativeValueTraits<IDLBoolean>::nativeValue(info.GetIsolate(), info[1], exceptionState);

if (exceptionState.hadException())

return;

- defaultUndefinedOptionalLongArg = toInt32(info.GetIsolate(), info[2], NormalConversion, exceptionState);

+ defaultUndefinedOptionalLongArg = NativeValueTraits<IDLLong>::nativeValue(info.GetIsolate(), info[2], exceptionState, NormalConversion);

if (exceptionState.hadException())

return;