third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp - Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp

Issue 2730183003: bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits. (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/core/v8/V8BindingForIDLTypes.h ('K') | « third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.h ('k') | third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp b/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp

index 2cf0502dce7dca845b16e830abe8a3ae0f3e6c28..c309618adcaf97db19e05672971249cb6bd25c19 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/DoubleOrString.cpp

@@ -11,7 +11,9 @@

// clang-format off

#include "DoubleOrString.h"

+#include "bindings/core/v8/IDLTypes.h"

#include "bindings/core/v8/ToV8.h"

+#include "bindings/core/v8/V8BindingForIDLTypes.h"

namespace blink {

@@ -66,7 +68,7 @@ void V8DoubleOrString::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v8Value

return;

if (v8Value->IsNumber()) {

- double cppValue = toRestrictedDouble(isolate, v8Value, exceptionState);

+ double cppValue = NativeValueTraits<IDLDouble>::nativeValue(isolate, v8Value, exceptionState);

if (exceptionState.hadException())

return;

impl.setDouble(cppValue);