bindings: Add C++ versions of WebIDL types and generalize NativeValueTraits.

third_party/WebKit/Source/bindings/core/v8/V8Binding.h

 /*
 * Copyright (C) 2009 Google Inc. All rights reserved.
 * Copyright (C) 2012 Ericsson AB. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
@@ skipping 22 matching lines @@
 #define V8Binding_h
 
 #include "bindings/core/v8/DOMDataStore.h"
 #include "bindings/core/v8/DOMWrapperWorld.h"
 #include "bindings/core/v8/ExceptionMessages.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/NativeValueTraits.h"
 #include "bindings/core/v8/ScriptState.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/ScriptWrappable.h"
+#include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/V8BindingMacros.h"
 #include "bindings/core/v8/V8PerIsolateData.h"
 #include "bindings/core/v8/V8ScriptRunner.h"
 #include "bindings/core/v8/V8StringResource.h"
 #include "bindings/core/v8/V8ThrowException.h"
 #include "bindings/core/v8/V8ValueCache.h"
 #include "core/CoreExport.h"
 #include "platform/heap/Handle.h"
 #include "v8/include/v8.h"
 #include "wtf/text/AtomicString.h"
@@ skipping 701 matching lines @@
     } else {
       exceptionState.throwTypeError("Invalid Array element type");
       return VectorType();
     }
   }
   return result;
 }
 
 // Converts a JavaScript value to an array as per the Web IDL specification:
 // http://www.w3.org/TR/2012/CR-WebIDL-20120419/#es-array
-template <typename VectorType>
+template <typename VectorType,
+          typename ValueType = typename VectorType::ValueType>
 VectorType toImplArray(v8::Local<v8::Value> value,
                        int argumentIndex,
                        v8::Isolate* isolate,
                        ExceptionState& exceptionState) {
-  typedef typename VectorType::ValueType ValueType;
   typedef NativeValueTraits<ValueType> TraitsType;
 
   uint32_t length = 0;
   if (value->IsArray()) {
     length = v8::Local<v8::Array>::Cast(value)->Length();
   } else if (!toV8Sequence(value, length, isolate, exceptionState)) {
     if (!exceptionState.hadException())
       exceptionState.throwTypeError(
           ExceptionMessages::notAnArrayTypeArgumentOrValue(argumentIndex));
     return VectorType();
@@ skipping 117 matching lines @@
               sequenceLength, block)) {
     exceptionState.rethrowV8Exception(block.Exception());
     return false;
   }
 
   length = sequenceLength;
   return true;
 }
 
 template <>
+struct NativeValueTraits<SerializedScriptValue>

[haraken, 2017/03/06 19:10:29]

Yeah, I'd prefer moving this to SerializedScriptValue.h. All type specialization
in this file should be gone.

[Raphael Kubo da Costa (rakuco), 2017/03/06 19:40:48]

Done in patch v6 \o/

+    : public NativeValueTraitsBase<SerializedScriptValue> {
+  CORE_EXPORT static inline PassRefPtr<SerializedScriptValue> nativeValue(
+      v8::Isolate* isolate,
+      v8::Local<v8::Value> value,
+      ExceptionState& exceptionState) {
+    return SerializedScriptValue::serialize(isolate, value, nullptr, nullptr,
+                                            exceptionState);
+  }
+};
+
+// TODO(rakuco): remove the specializations below (and consequently the
+// non-IDLBase version of NativeValueTraitsBase) once we manage to convert all
+// uses of NativeValueTraits to types that derive from IDLBase or for generated
+// IDL interfaces/dictionaries/unions.
+template <>
 struct NativeValueTraits<String> {
   static inline String nativeValue(v8::Isolate* isolate,
                                    v8::Local<v8::Value> value,
                                    ExceptionState& exceptionState) {
     V8StringResource<> stringValue(value);
     if (!stringValue.prepare(exceptionState))
       return String();
     return stringValue;
   }
 };
@@ skipping 243 matching lines @@
 // If the argument isn't an object, this will crash.
 CORE_EXPORT v8::Local<v8::Value> freezeV8Object(v8::Local<v8::Value>,
                                                 v8::Isolate*);
 
 CORE_EXPORT v8::Local<v8::Value> fromJSONString(v8::Isolate*,
                                                 const String& stringifiedJSON,
                                                 ExceptionState&);
 }  // namespace blink
 
 #endif  // V8Binding_h