Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 273016: Don't draw the red line when the security level is SECURE.... (Closed)

Created:
11 years, 2 months ago by Yusuke Sato
Modified:
9 years, 7 months ago
Reviewers:
Daniel Erat, Evan Stade
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Don't draw the red line when the security level is SECURE. BUG=24510 TEST=see the bug

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yusuke Sato
Evan, can you review this?
11 years, 2 months ago (2009-10-10 17:15:06 UTC) #1
Daniel Erat
LGTM Sorry, I should've caught this. :-(
11 years, 2 months ago (2009-10-10 17:40:26 UTC) #2
Yusuke Sato
Thanks, submitted: http://src.chromium.org/viewvc/chrome?view=rev&revision=28667
11 years, 2 months ago (2009-10-10 18:22:58 UTC) #3
Evan Stade
sorry for this regression, however this causes another regression: http://codereview.chromium.org/272028/show
11 years, 2 months ago (2009-10-12 18:37:11 UTC) #4
Yusuke Sato
11 years, 2 months ago (2009-10-13 02:30:19 UTC) #5
ugh, thanks for the fix.

Powered by Google App Engine
This is Rietveld 408576698