third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2730123003: [Presentation API] Add layout test for connection.close() and fix test failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2730123003: [Presentation API] Add layout test for connection.close() and fix test failures (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/presentation/presentation-controller-close-connection.html ('K') | « third_party/WebKit/Source/modules/presentation/PresentationConnection.h ('k') | third_party/WebKit/public/platform/modules/presentation/WebPresentationConnection.h » ('j') | third_party/WebKit/public/platform/modules/presentation/WebPresentationConnection.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index 142918d8fb523498cfd22803d009d0f9d30c6d64..67e4bfd7178e168b311567a240c439dd8c2e15ac 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -459,7 +459,7 @@ void PresentationConnection::didChangeState(

void PresentationConnection::didClose(

WebPresentationConnectionCloseReason reason,

- const String& message) {

+ const WebString& message) {

if (m_state == WebPresentationConnectionState::Closed)

return;